Unverified Commit 11074318 authored Jul 04, 2018 by Srinivas Kandagatla Committed by Mark Brown Jul 04, 2018

ASoC: qdsp6: q6afe-dai: do not close port if its not opened



afe ports are open as part of prepare, so for use cases like
"aplay sample.wav" were sample.wav is not present. This would
call port close eventhough port was never opened. DSP would
return errors for such use cases.

Avoid doing this by checking the port state.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 4febced1

sound/soc/qcom/qdsp6/q6afe-dai.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -315,6 +315,9 @@ static void q6afe_dai_shutdown(struct snd_pcm_substream *substream,
		struct q6afe_dai_data *dai_data = dev_get_drvdata(dai->dev);
		int rc;

		if (!dai_data->is_port_started[dai->id])
		return;

		rc = q6afe_port_stop(dai_data->port[dai->id]);
		if (rc < 0)
		dev_err(dai->dev, "fail to close AFE port (%d)\n", rc);