Commit 10cdfe54 authored Dec 02, 2014 by Tomeu Vizoso Committed by Michael Turquette Dec 03, 2014

clk: Don't try to use a struct clk* after it could have been freed



As __clk_release could call kfree on clk and then we wouldn't have a safe way
of getting the module that owns the clock.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Fixes: fcb0ee6a ("clk: Implement clk_unregister")
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Michael Turquette <mturquette@linaro.org>

parent 4afbe176

drivers/clk/clk.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -2268,14 +2268,17 @@ int __clk_get(struct clk *clk)

		void __clk_put(struct clk *clk)
		{
		struct module *owner;

		if (!clk \|\| WARN_ON_ONCE(IS_ERR(clk)))
		return;

		clk_prepare_lock();
		owner = clk->owner;
		kref_put(&clk->ref, __clk_release);
		clk_prepare_unlock();

		module_put(clk->owner);
		module_put(owner);
		}

		/* clk rate change notifiers */