Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 10add84e authored by Mike Snitzer's avatar Mike Snitzer
Browse files

dm cache metadata: fail operations if fail_io mode has been established 



Otherwise it is possible to trigger crashes due to the metadata being
inaccessible yet these methods don't safely account for that possibility
without these checks.

Cc: stable@vger.kernel.org
Reported-by: default avatarMikulas Patocka <mpatocka@redhat.com>
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
parent 7ab84db6

drivers/md/dm-cache-metadata.c

+8 −4
Original line number Diff line number Diff line
@@ -1624,17 +1624,19 @@ void dm_cache_metadata_set_stats(struct dm_cache_metadata *cmd, 


int dm_cache_commit(struct dm_cache_metadata *cmd, bool clean_shutdown)

{

	int r;

	int r = -EINVAL;

	flags_mutator mutator = (clean_shutdown ? set_clean_shutdown :

				 clear_clean_shutdown);



	WRITE_LOCK(cmd);

	if (cmd->fail_io)

		goto out;



	r = __commit_transaction(cmd, mutator);

	if (r)

		goto out;



	r = __begin_transaction(cmd);



out:

	WRITE_UNLOCK(cmd);

	return r;
@@ -1646,6 +1648,7 @@ int dm_cache_get_free_metadata_block_count(struct dm_cache_metadata *cmd, 
	int r = -EINVAL;



	READ_LOCK(cmd);

	if (!cmd->fail_io)

		r = dm_sm_get_nr_free(cmd->metadata_sm, result);

	READ_UNLOCK(cmd);
@@ -1658,6 +1661,7 @@ int dm_cache_get_metadata_dev_size(struct dm_cache_metadata *cmd, 
	int r = -EINVAL;



	READ_LOCK(cmd);

	if (!cmd->fail_io)

		r = dm_sm_get_nr_blocks(cmd->metadata_sm, result);

	READ_UNLOCK(cmd);