Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 10804f0f authored by Stephen Rothwell's avatar Stephen Rothwell Committed by Paul Mackerras
Browse files

[POWERPC] therm_adt746x: Eliminate some build warnings 



We don't care if the device_create_file calls fail, the driver will work
just as well without them, so just issue a runtime warning.

drivers/macintosh/therm_adt746x.c: In function 'thermostat_init':
drivers/macintosh/therm_adt746x.c:615: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result
drivers/macintosh/therm_adt746x.c:616: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result
drivers/macintosh/therm_adt746x.c:617: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result
drivers/macintosh/therm_adt746x.c:618: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result
drivers/macintosh/therm_adt746x.c:619: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result
drivers/macintosh/therm_adt746x.c:620: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result
drivers/macintosh/therm_adt746x.c:621: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result
drivers/macintosh/therm_adt746x.c:622: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result
drivers/macintosh/therm_adt746x.c:623: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result
drivers/macintosh/therm_adt746x.c:625: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result

Signed-off-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: default avatarPaul Mackerras <paulus@samba.org>
parent 98894dff

drivers/macintosh/therm_adt746x.c

+14 −10
Original line number Diff line number Diff line
@@ -553,6 +553,7 @@ thermostat_init(void) 
	struct device_node* np;

	const u32 *prop;

	int i = 0, offset = 0;

	int err;

	

	np = of_find_node_by_name(NULL, "fan");

	if (!np)
@@ -612,17 +613,20 @@ thermostat_init(void) 
		return -ENODEV;

	}

	

	device_create_file(&of_dev->dev, &dev_attr_sensor1_temperature);

	device_create_file(&of_dev->dev, &dev_attr_sensor2_temperature);

	device_create_file(&of_dev->dev, &dev_attr_sensor1_limit);

	device_create_file(&of_dev->dev, &dev_attr_sensor2_limit);

	device_create_file(&of_dev->dev, &dev_attr_sensor1_location);

	device_create_file(&of_dev->dev, &dev_attr_sensor2_location);

	device_create_file(&of_dev->dev, &dev_attr_limit_adjust);

	device_create_file(&of_dev->dev, &dev_attr_specified_fan_speed);

	device_create_file(&of_dev->dev, &dev_attr_sensor1_fan_speed);

	err = device_create_file(&of_dev->dev, &dev_attr_sensor1_temperature);

	err |= device_create_file(&of_dev->dev, &dev_attr_sensor2_temperature);

	err |= device_create_file(&of_dev->dev, &dev_attr_sensor1_limit);

	err |= device_create_file(&of_dev->dev, &dev_attr_sensor2_limit);

	err |= device_create_file(&of_dev->dev, &dev_attr_sensor1_location);

	err |= device_create_file(&of_dev->dev, &dev_attr_sensor2_location);

	err |= device_create_file(&of_dev->dev, &dev_attr_limit_adjust);

	err |= device_create_file(&of_dev->dev, &dev_attr_specified_fan_speed);

	err |= device_create_file(&of_dev->dev, &dev_attr_sensor1_fan_speed);

	if(therm_type == ADT7460)

		device_create_file(&of_dev->dev, &dev_attr_sensor2_fan_speed);

		err |= device_create_file(&of_dev->dev, &dev_attr_sensor2_fan_speed);

	if (err)

		printk(KERN_WARNING

			"Failed to create tempertaure attribute file(s).\n");



#ifndef CONFIG_I2C_POWERMAC

	request_module("i2c-powermac");