Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 108019a7 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Eric Anholt
Browse files

drm/pl111: Use 64-bit arithmetic instead of 32-bit 



Add suffix ULL to constant 1000 in order to give the compiler complete
information about the proper arithmetic to use.

Notice that such constant is used in a context that expects an
expression of type u64 (64 bits, unsigned) and the following
expression is currently being evaluated using 32-bit arithmetic:

mode->clock * 1000

Addresses-Coverity-ID: 1466139 ("Unintentional integer overflow")
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarEric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20180704142255.GA8614@embeddedor.com
parent f9760772

drivers/gpu/drm/pl111/pl111_display.c

+1 −1
Original line number Diff line number Diff line
@@ -63,7 +63,7 @@ pl111_mode_valid(struct drm_crtc *crtc, 
	 * We use the pixelclock to also account for interlaced modes, the

	 * resulting bandwidth is in bytes per second.

	 */

	bw = mode->clock * 1000; /* In Hz */

	bw = mode->clock * 1000ULL; /* In Hz */

	bw = bw * mode->hdisplay * mode->vdisplay * cpp;

	bw = div_u64(bw, mode->htotal * mode->vtotal);