Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0fdf4d09 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

bnx2x: fix wrong return from bnx2x_trylock_hw_lock 



bnx2x_trylock_hw_lock() returns a bool :

true if succeeded to acquire the lock.
false in case of error.

-EINVAL is not an acceptable value, since its promoted to true.

Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Acked-by: default avatarEilon Greenstein <eilong@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 40d0802b

drivers/net/bnx2x/bnx2x_main.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -781,7 +781,7 @@ static bool bnx2x_trylock_hw_lock(struct bnx2x *bp, u32 resource) 
		DP(NETIF_MSG_HW,

		DP(NETIF_MSG_HW,

		   "resource(0x%x) > HW_LOCK_MAX_RESOURCE_VALUE(0x%x)\n",

		   "resource(0x%x) > HW_LOCK_MAX_RESOURCE_VALUE(0x%x)\n",

		   resource, HW_LOCK_MAX_RESOURCE_VALUE);

		   resource, HW_LOCK_MAX_RESOURCE_VALUE);

		return -EINVAL;

		return false;

	}

	}





	if (func <= 5)

	if (func <= 5)