Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0fc4dffa authored by Erik Hugne's avatar Erik Hugne Committed by David S. Miller
Browse files

tipc: fix sparse warnings 



This fixes the following sparse warnings:
sparse: symbol 'tipc_update_nametbl' was not declared. Should it be static?
Also, the function is changed to return bool upon success, rather than a
potentially freed pointer.

Signed-off-by: default avatarErik Hugne <erik.hugne@ericsson.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cf98192d

net/tipc/name_distr.c

+4 −3
Original line number Diff line number Diff line
@@ -284,8 +284,7 @@ static void named_purge_publ(struct publication *publ) 
 * tipc_nametbl_lock must be held.

 * Returns the publication item if successful, otherwise NULL.

 */

struct publication *tipc_update_nametbl(struct distr_item *i, u32 node,

					u32 dtype)

static bool tipc_update_nametbl(struct distr_item *i, u32 node, u32 dtype)

{

	struct publication *publ = NULL;
@@ -298,6 +297,7 @@ struct publication *tipc_update_nametbl(struct distr_item *i, u32 node, 
			tipc_nodesub_subscribe(&publ->subscr, node, publ,

					       (net_ev_handler)

					       named_purge_publ);

			return true;

		}

	} else if (dtype == WITHDRAWAL) {

		publ = tipc_nametbl_remove_publ(ntohl(i->type), ntohl(i->lower),
@@ -306,11 +306,12 @@ struct publication *tipc_update_nametbl(struct distr_item *i, u32 node, 
		if (publ) {

			tipc_nodesub_unsubscribe(&publ->subscr);

			kfree(publ);

			return true;

		}

	} else {

		pr_warn("Unrecognized name table message received\n");

	}

	return publ;

	return false;

}



/**