Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0f4cfb2e authored by Oleg Nesterov's avatar Oleg Nesterov Committed by Linus Torvalds
Browse files

coredump: use SUID_DUMPABLE_ENABLED rather than hardcoded 1 



Cosmetic. Change setup_new_exec() and task_dumpable() to use
SUID_DUMPABLE_ENABLED for /bin/grep.

[akpm@linux-foundation.org: checkpatch fixes]
Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 12a2b4b2

fs/exec.c

+1 −1
Original line number Diff line number Diff line
@@ -1097,7 +1097,7 @@ void setup_new_exec(struct linux_binprm * bprm) 
	current->sas_ss_sp = current->sas_ss_size = 0;



	if (uid_eq(current_euid(), current_uid()) && gid_eq(current_egid(), current_gid()))

		set_dumpable(current->mm, 1);

		set_dumpable(current->mm, SUID_DUMPABLE_ENABLED);

	else

		set_dumpable(current->mm, suid_dumpable);

fs/proc/internal.h

+1 −1
Original line number Diff line number Diff line
@@ -103,7 +103,7 @@ static inline int task_dumpable(struct task_struct *task) 
	if (mm)

		dumpable = get_dumpable(mm);

	task_unlock(task);

	if(dumpable == 1)

	if (dumpable == SUID_DUMPABLE_ENABLED)

		return 1;

	return 0;

}