Commit 0f0f1b40 authored Sep 25, 2006 by Alan Cox Committed by Linus Torvalds Sep 26, 2006

[PATCH] Voyager: tty locking



Voyager fiddles with current->signal.tty without locking.  It turns out
that the code in question has already cleared current->signal.tty correctly
because daemonize() does the right thing already.

The signal handling also appears to be incorrect as it does an unprotected
sigfillset that also appears unneccessary.  As I don't have a bowtie and am
therefore not a qualified voyager maintainer I leave that to James.

Signed-off-by: Alan Cox <alan@redhat.com>
Acked-by: James Bottomley <James.Bottomley@steeleye.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent a3bc0dbc

arch/i386/mach-voyager/voyager_thread.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -130,7 +130,6 @@ thread(void *unused)
		init_timer(&wakeup_timer);

		sigfillset(&current->blocked);
		current->signal->tty = NULL;

		printk(KERN_NOTICE "Voyager starting monitor thread\n");