Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0f0d1510 authored by Michael Chan's avatar Michael Chan Committed by David S. Miller
Browse files

tg3: Fix data corruption on 5725 with TSO 



The 5725 family of devices (asic rev 5762), corrupts TSO packets where
the buffer is within MSS bytes of a 4G boundary (4G, 8G etc.). Detect
this condition and trigger the workaround path.

Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarMichael Chan <mchan@broadcom.com>
Signed-off-by: default avatarNithin Nayak Sujir <nsujir@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 44f3b503

drivers/net/ethernet/broadcom/tg3.c

+17 −0
Original line number Diff line number Diff line
@@ -7448,6 +7448,20 @@ static inline int tg3_4g_overflow_test(dma_addr_t mapping, int len) 
	return (base > 0xffffdcc0) && (base + len + 8 < base);

}



/* Test for TSO DMA buffers that cross into regions which are within MSS bytes

 * of any 4GB boundaries: 4G, 8G, etc

 */

static inline int tg3_4g_tso_overflow_test(struct tg3 *tp, dma_addr_t mapping,

					   u32 len, u32 mss)

{

	if (tg3_asic_rev(tp) == ASIC_REV_5762 && mss) {

		u32 base = (u32) mapping & 0xffffffff;



		return ((base + len + (mss & 0x3fff)) < base);

	}

	return 0;

}



/* Test for DMA addresses > 40-bit */

static inline int tg3_40bit_overflow_test(struct tg3 *tp, dma_addr_t mapping,

					  int len)
@@ -7484,6 +7498,9 @@ static bool tg3_tx_frag_set(struct tg3_napi *tnapi, u32 *entry, u32 *budget, 
	if (tg3_4g_overflow_test(map, len))

		hwbug = true;



	if (tg3_4g_tso_overflow_test(tp, map, len, mss))

		hwbug = true;



	if (tg3_40bit_overflow_test(tp, map, len))

		hwbug = true;