Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0d1c6d1c authored by Wei Yongjun's avatar Wei Yongjun Committed by John W. Linville
Browse files

airo: use is_zero_ether_addr() and is_broadcast_ether_addr() 

Using is_zero_ether_addr() and is_broadcast_ether_addr() instead of
directly use memcmp() to determine if the ethernet address is all zeros.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/

)

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent c3a2ee93

drivers/net/wireless/airo.c

+2 −4
Original line number Diff line number Diff line
@@ -5976,13 +5976,11 @@ static int airo_set_wap(struct net_device *dev, 
	Cmd cmd;

	Resp rsp;

	APListRid APList_rid;

	static const u8 any[ETH_ALEN] = { 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF };

	static const u8 off[ETH_ALEN] = { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };



	if (awrq->sa_family != ARPHRD_ETHER)

		return -EINVAL;

	else if (!memcmp(any, awrq->sa_data, ETH_ALEN) ||

	         !memcmp(off, awrq->sa_data, ETH_ALEN)) {

	else if (is_broadcast_ether_addr(awrq->sa_data) ||

		 is_zero_ether_addr(awrq->sa_data)) {

		memset(&cmd, 0, sizeof(cmd));

		cmd.cmd=CMD_LOSE_SYNC;

		if (down_interruptible(&local->sem))