Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0c0cbb6c authored by Bjorn Helgaas's avatar Bjorn Helgaas
Browse files

PCI/ASPM: Simplify Clock Power Management setting 



Update the Link Control Enable Clock Power Management bit the same
way we update the ASPM Control bits, with a single call of
pcie_capability_clear_and_set_word().

No functional change; this just makes both paths use the same style.

Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent 777e61ea

drivers/pci/pcie/aspm.c

+5 −8
Original line number Diff line number Diff line
@@ -127,15 +127,12 @@ static void pcie_set_clkpm_nocheck(struct pcie_link_state *link, int enable) 
{

	struct pci_dev *child;

	struct pci_bus *linkbus = link->pdev->subordinate;

	u32 val = enable ? PCI_EXP_LNKCTL_CLKREQ_EN : 0;



	list_for_each_entry(child, &linkbus->devices, bus_list) {

		if (enable)

			pcie_capability_set_word(child, PCI_EXP_LNKCTL,

						 PCI_EXP_LNKCTL_CLKREQ_EN);

		else

			pcie_capability_clear_word(child, PCI_EXP_LNKCTL,

						   PCI_EXP_LNKCTL_CLKREQ_EN);

	}

	list_for_each_entry(child, &linkbus->devices, bus_list)

		pcie_capability_clear_and_set_word(child, PCI_EXP_LNKCTL,

						   PCI_EXP_LNKCTL_CLKREQ_EN,

						   val);

	link->clkpm_enabled = !!enable;

}