Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0bffd25c authored by Ben Hutchings's avatar Ben Hutchings Committed by Greg Kroah-Hartman
Browse files

tools/hv: Fix permissions of created directory and files 



It's silly to create directories without execute permission, or to
give permissions to 'other' but not the group-owner.

Write the permissions in octal and 'ls -l' format since these are much
easier to read than the named macros.

Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
Signed-off-by: default avatarTomas Hozza <thozza@redhat.com>
Acked-by: default avatarK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 40424f5f

tools/hv/hv_kvp_daemon.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -235,7 +235,7 @@ static int kvp_file_init(void) 
	int alloc_unit = sizeof(struct kvp_record) * ENTRIES_PER_BLOCK;

	int alloc_unit = sizeof(struct kvp_record) * ENTRIES_PER_BLOCK;





	if (access(KVP_CONFIG_LOC, F_OK)) {

	if (access(KVP_CONFIG_LOC, F_OK)) {

		if (mkdir(KVP_CONFIG_LOC, S_IRUSR | S_IWUSR | S_IROTH)) {

		if (mkdir(KVP_CONFIG_LOC, 0755 /* rwxr-xr-x */)) {

			syslog(LOG_ERR, " Failed to create %s", KVP_CONFIG_LOC);

			syslog(LOG_ERR, " Failed to create %s", KVP_CONFIG_LOC);

			exit(EXIT_FAILURE);

			exit(EXIT_FAILURE);

		}

		}
@@ -246,7 +246,7 @@ static int kvp_file_init(void) 
		records_read = 0;

		records_read = 0;

		num_blocks = 1;

		num_blocks = 1;

		sprintf(fname, "%s/.kvp_pool_%d", KVP_CONFIG_LOC, i);

		sprintf(fname, "%s/.kvp_pool_%d", KVP_CONFIG_LOC, i);

		fd = open(fname, O_RDWR | O_CREAT, S_IRUSR | S_IWUSR | S_IROTH);

		fd = open(fname, O_RDWR | O_CREAT, 0644 /* rw-r--r-- */);





		if (fd == -1)

		if (fd == -1)

			return 1;

			return 1;