Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0b50d753 authored by Ishizaki Kou's avatar Ishizaki Kou Committed by Jeff Garzik
Browse files

spidernet: revise link status logging 



This patch revises the logging for link informations of spidernet.

  - The link down message is too verbose because auto-negotiation timeout
    occurs periodically while an ethernet cable is not connected.
  - We want to see the link result, and we think it should be displayed.

Signed-off-by: default avatarKou Ishizaki <kou.ishizaki@toshiba.co.jp>
Acked-by: default avatarJens Osterkamp <jens@de.ibm.com>
Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
parent 9a11fcb5

drivers/net/spider_net.c

+6 −4
Original line number Diff line number Diff line
@@ -2045,7 +2045,8 @@ static void spider_net_link_phy(unsigned long data) 
	/* if link didn't come up after SPIDER_NET_ANEG_TIMEOUT tries, setup phy again */

	if (card->aneg_count > SPIDER_NET_ANEG_TIMEOUT) {



		pr_info("%s: link is down trying to bring it up\n", card->netdev->name);

		pr_debug("%s: link is down trying to bring it up\n",

			 card->netdev->name);



		switch (card->medium) {

		case BCM54XX_COPPER:
@@ -2096,8 +2097,9 @@ static void spider_net_link_phy(unsigned long data) 


	card->aneg_count = 0;



	pr_debug("Found %s with %i Mbps, %s-duplex %sautoneg.\n",

		phy->def->name, phy->speed, phy->duplex==1 ? "Full" : "Half",

	pr_info("%s: link up, %i Mbps, %s-duplex %sautoneg.\n",

		card->netdev->name, phy->speed,

		phy->duplex == 1 ? "Full" : "Half",

		phy->autoneg == 1 ? "" : "no ");



	return;