Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a98babd authored by Markus Elfring's avatar Markus Elfring Committed by Borislav Petkov
Browse files

EDAC: Delete unnecessary check before calling pci_dev_put() 



The pci_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test before the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Link: http://lkml.kernel.org/r/546CB20D.4070808@users.sourceforge.net


[ Boris: commit message. ]
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
parent 19ca5a3c

drivers/edac/i3000_edac.c

+1 −2
Original line number Original line Diff line number Diff line
@@ -542,7 +542,6 @@ static int __init i3000_init(void) 
	pci_unregister_driver(&i3000_driver);

	pci_unregister_driver(&i3000_driver);





fail0:

fail0:

	if (mci_pdev)

	pci_dev_put(mci_pdev);

	pci_dev_put(mci_pdev);





	return pci_rc;

	return pci_rc;

drivers/edac/i3200_edac.c

+1 −2
Original line number Original line Diff line number Diff line
@@ -523,7 +523,6 @@ static int __init i3200_init(void) 
	pci_unregister_driver(&i3200_driver);

	pci_unregister_driver(&i3200_driver);





fail0:

fail0:

	if (mci_pdev)

	pci_dev_put(mci_pdev);

	pci_dev_put(mci_pdev);





	return pci_rc;

	return pci_rc;

drivers/edac/i82443bxgx_edac.c

+1 −2
Original line number Original line Diff line number Diff line
@@ -458,7 +458,6 @@ static void __exit i82443bxgx_edacmc_exit(void) 
	if (!i82443bxgx_registered)

	if (!i82443bxgx_registered)

		i82443bxgx_edacmc_remove_one(mci_pdev);

		i82443bxgx_edacmc_remove_one(mci_pdev);





	if (mci_pdev)

	pci_dev_put(mci_pdev);

	pci_dev_put(mci_pdev);

}

}

drivers/edac/x38_edac.c

+1 −2
Original line number Original line Diff line number Diff line
@@ -500,7 +500,6 @@ static int __init x38_init(void) 
	pci_unregister_driver(&x38_driver);

	pci_unregister_driver(&x38_driver);





fail0:

fail0:

	if (mci_pdev)

	pci_dev_put(mci_pdev);

	pci_dev_put(mci_pdev);





	return pci_rc;

	return pci_rc;