Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a3e92de authored by Jacob Keller's avatar Jacob Keller Committed by Jeff Kirsher
Browse files

fm10k: don't protect fm10k_queue_mac_request by fm10k_host_mbx_ready 



We don't actually need to check if the host mbx is ready when queuing
MAC requests, because these are not handled by a special queue which
queues up requests until the mailbox is capable of handling them.

Pull these requests outside the fm10k_host_mbx_ready() check, as it is
not necessary.

Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Tested-by: default avatarKrishneil Singh <krishneil.k.singh@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 454ca380

drivers/net/ethernet/intel/fm10k/fm10k_netdev.c

+8 −8
Original line number Diff line number Diff line
@@ -1537,12 +1537,12 @@ static void *fm10k_dfwd_add_station(struct net_device *dev, 


	glort = l2_accel->dglort + 1 + i;



	if (fm10k_host_mbx_ready(interface)) {

	if (fm10k_host_mbx_ready(interface))

		hw->mac.ops.update_xcast_mode(hw, glort,

					      FM10K_XCAST_MODE_NONE);



	fm10k_queue_mac_request(interface, glort, sdev->dev_addr,

				hw->mac.default_vid, true);

	}



	for (vid = fm10k_find_next_vlan(interface, 0);

	     vid < VLAN_N_VID;
@@ -1583,12 +1583,12 @@ static void fm10k_dfwd_del_station(struct net_device *dev, void *priv) 


	glort = l2_accel->dglort + 1 + i;



	if (fm10k_host_mbx_ready(interface)) {

	if (fm10k_host_mbx_ready(interface))

		hw->mac.ops.update_xcast_mode(hw, glort,

					      FM10K_XCAST_MODE_NONE);



	fm10k_queue_mac_request(interface, glort, sdev->dev_addr,

				hw->mac.default_vid, false);

	}



	for (vid = fm10k_find_next_vlan(interface, 0);

	     vid < VLAN_N_VID;