Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0986f25f authored Mar 15, 2011 by Dan Carpenter Committed by Matthew Garrett Mar 28, 2011

asus-wmi: signedness bug in read_brightness()



"err" needs to be signed for the error handling to work.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>

parent 27836584

drivers/platform/x86/asus-wmi.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -946,7 +946,8 @@ static int read_brightness_max(struct asus_wmi *asus)
		static int read_brightness(struct backlight_device *bd)
		{
		struct asus_wmi *asus = bl_get_data(bd);
		u32 retval, err;
		u32 retval;
		int err;

		err = asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_BRIGHTNESS, &retval);