Commit 096a8b6d authored May 03, 2016 by James Hogan

metag: Fix atomic_*_return inline asm constraints



The argument i of atomic_*_return() operations is given to inline asm
with the "bd" constraint, which means "An Op2 register where Op1 is a
data unit register and the instruction supports O2R", however Op1 is
constrained by "da" which allows an address unit register to be used.

Fix the constraint to use "br", meaning "An Op2 register and the
instruction supports O2R", i.e. not requiring Op1 to be a data unit
register.

Fixes: d6dfe250 ("locking,arch,metag: Fold atomic_ops")
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: linux-metag@vger.kernel.org

parent f5d163aa

arch/metag/include/asm/atomic_lnkget.h

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -61,7 +61,7 @@ static inline int atomic_##op##_return(int i, atomic_t *v) \
	" CMPT %0, #HI(0x02000000)\n" \		" CMPT %0, #HI(0x02000000)\n" \
	" BNZ 1b\n" \		" BNZ 1b\n" \
	: "=&d" (temp), "=&da" (result) \		: "=&d" (temp), "=&da" (result) \
	: "da" (&v->counter), "bd" (i) \		: "da" (&v->counter), "br" (i) \
	: "cc"); \		: "cc"); \
	\		\
	smp_mb(); \		smp_mb(); \