Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 08d18f3b authored by Anton Vorontsov's avatar Anton Vorontsov Committed by David S. Miller
Browse files

fsl_pq_mdio: Fix mdiobus allocation handling 



The driver could return success code even if mdiobus_alloc() failed.
This patch fixes the issue.

Signed-off-by: default avatarAnton Vorontsov <avorontsov@mvista.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a2f79227

drivers/net/fsl_pq_mdio.c

+4 −2
Original line number Diff line number Diff line
@@ -277,15 +277,17 @@ static int fsl_pq_mdio_probe(struct of_device *ofdev, 
	int tbiaddr = -1;

	const u32 *addrp;

	u64 addr = 0, size = 0;

	int err = 0;

	int err;



	priv = kzalloc(sizeof(*priv), GFP_KERNEL);

	if (!priv)

		return -ENOMEM;



	new_bus = mdiobus_alloc();

	if (NULL == new_bus)

	if (!new_bus) {

		err = -ENOMEM;

		goto err_free_priv;

	}



	new_bus->name = "Freescale PowerQUICC MII Bus",

	new_bus->read = &fsl_pq_mdio_read,