Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 08be1a79 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Linus Walleij
Browse files

gpiolib: acpi: Don't contaminate return parameter in case of error 



If error occurs, leave lookup parameter untouched.

There is no functional change, since all current callers just bail out
in case of error without using the assigned pieces.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent f67a6c11

drivers/gpio/gpiolib-acpi.c

+1 −1
Original line number Diff line number Diff line
@@ -585,7 +585,6 @@ static int acpi_gpio_property_lookup(struct fwnode_handle *fwnode, 
	 * The property was found and resolved, so need to lookup the GPIO based

	 * on returned args.

	 */

	lookup->adev = args.adev;

	if (args.nargs != 3)

		return -EPROTO;
@@ -593,6 +592,7 @@ static int acpi_gpio_property_lookup(struct fwnode_handle *fwnode, 
	lookup->pin_index = args.args[1];

	lookup->active_low = !!args.args[2];



	lookup->adev = args.adev;

	return 0;

}