Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 087d9753 authored by Sowmini Varadhan's avatar Sowmini Varadhan Committed by David S. Miller
Browse files

rds: tcp: canonical connection order for all paths with index > 0 



The rds_connect_worker() has a bug in the check that enforces the
canonical connection order described in the comments of
rds_tcp_state_change(). The intention is to make sure that all
the multipath connections are always initiated by the smaller IP
address via rds_start_mprds. To achieve this, rds_connection_worker
should check that cp_index > 0.

Signed-off-by: default avatarSowmini Varadhan <sowmini.varadhan@oracle.com>
Acked-by: default avatarSantosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e97656d0

net/rds/threads.c

+1 −1
Original line number Diff line number Diff line
@@ -156,7 +156,7 @@ void rds_connect_worker(struct work_struct *work) 
	struct rds_connection *conn = cp->cp_conn;

	int ret;



	if (cp->cp_index > 1 && cp->cp_conn->c_laddr > cp->cp_conn->c_faddr)

	if (cp->cp_index > 0 && cp->cp_conn->c_laddr > cp->cp_conn->c_faddr)

		return;

	clear_bit(RDS_RECONNECT_PENDING, &cp->cp_flags);

	ret = rds_conn_path_transition(cp, RDS_CONN_DOWN, RDS_CONN_CONNECTING);