Commit 07e9293c authored Dec 02, 2016 by Sean Young Committed by Mauro Carvalho Chehab Jan 30, 2017

[media] lirc: LIRC_{G,S}ET_SEND_MODE fail if device cannot transmit



These ioctls should not succeed if the device cannot send. Also make it
clear that these ioctls should return the lirc mode, although the actual
value does not change.

Signed-off-by: Sean Young <sean@mess.org>
Reviewed-by: Andi Shyti <andi.shyti@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

parent bd291208

drivers/media/rc/ir-lirc-codec.c

+8 −2

Original line number	Diff line number	Diff line
		@@ -204,11 +204,17 @@ static long ir_lirc_ioctl(struct file *filep, unsigned int cmd,

		/* legacy support */
		case LIRC_GET_SEND_MODE:
		val = LIRC_CAN_SEND_PULSE & LIRC_CAN_SEND_MASK;
		if (!dev->tx_ir)
		return -ENOTTY;

		val = LIRC_MODE_PULSE;
		break;

		case LIRC_SET_SEND_MODE:
		if (val != (LIRC_MODE_PULSE & LIRC_CAN_SEND_MASK))
		if (!dev->tx_ir)
		return -ENOTTY;

		if (val != LIRC_MODE_PULSE)
		return -EINVAL;
		return 0;