Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 075663d1 authored by Srivatsa S. Bhat's avatar Srivatsa S. Bhat Committed by Linus Torvalds
Browse files

CPU hotplug, debug: detect imbalance between get_online_cpus() and put_online_cpus() 



The synchronization between CPU hotplug readers and writers is achieved
by means of refcounting, safeguarded by the cpu_hotplug.lock.

get_online_cpus() increments the refcount, whereas put_online_cpus()
decrements it.  If we ever hit an imbalance between the two, we end up
compromising the guarantees of the hotplug synchronization i.e, for
example, an extra call to put_online_cpus() can end up allowing a
hotplug reader to execute concurrently with a hotplug writer.

So, add a WARN_ON() in put_online_cpus() to detect such cases where the
refcount can go negative, and also attempt to fix it up, so that we can
continue to run.

Signed-off-by: default avatarSrivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Reviewed-by: default avatarYasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 7ac57a89

kernel/cpu.c

+4 −0
Original line number Diff line number Diff line
@@ -80,6 +80,10 @@ void put_online_cpus(void) 
	if (cpu_hotplug.active_writer == current)

		return;

	mutex_lock(&cpu_hotplug.lock);



	if (WARN_ON(!cpu_hotplug.refcount))

		cpu_hotplug.refcount++; /* try to fix things up */



	if (!--cpu_hotplug.refcount && unlikely(cpu_hotplug.active_writer))

		wake_up_process(cpu_hotplug.active_writer);

	mutex_unlock(&cpu_hotplug.lock);