Commit 074604af authored Feb 04, 2013 by Jason Wessel

kdb_main: fix help print



The help command was chopping all the usage instructions such that
they were not readable.

Example:

bta             [D|R|S|T|C|Z|E|U|I| Backtrace all processes matching state flag
per_cpu         <sym> [<bytes>] [<c Display per_cpu variables

Where as it should look like:

bta             [D|R|S|T|C|Z|E|U|I|M|A]
                                    Backtrace all processes matching state flag
per_cpu         <sym> [<bytes>] [<cpu>]
                                    Display per_cpu variables

All that is needed is to check the how long the cmd_usage is and jump
to the next line when appropriate.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>

parent 4eb7a66d

kernel/debug/kdb/kdb_main.c

+7 −3

Original line number	Diff line number	Diff line
		@@ -2442,11 +2442,15 @@ static int kdb_help(int argc, const char **argv)
		kdb_printf("-----------------------------"
		"-----------------------------\n");
		for_each_kdbcmd(kt, i) {
		if (kt->cmd_name)
		kdb_printf("%-15.15s %-20.20s %s\n", kt->cmd_name,
		kt->cmd_usage, kt->cmd_help);
		char *space = "";
		if (KDB_FLAG(CMD_INTERRUPT))
		return 0;
		if (!kt->cmd_name)
		continue;
		if (strlen(kt->cmd_usage) > 20)
		space = "\n ";
		kdb_printf("%-15.15s %-20s%s%s\n", kt->cmd_name,
		kt->cmd_usage, space, kt->cmd_help);
		}
		return 0;
		}