Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 07354a00 authored by Adam B. Jerome's avatar Adam B. Jerome Committed by Linus Torvalds
Browse files

[PATCH] /proc/kallsyms reports lower-case types for some non-exported symbols 



This patch addresses incorrect symbol type information reported through
/proc/kallsyms.  A lowercase character should designate the symbol as local
(or non-exported).  An uppercase character should designate the symbol as
global (or external).

Without this patch, some non-exported symbols are incorrectly assigned an
upper-case designation in /proc/kallsyms.  This patch corrects this
condition by converting non-exported symbols types to lower case when
appropriate and eliminates the superfluous upcase_if_global function

Signed-off-by: default avatarAdam B. Jerome <abj@novell.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 960cc398

kernel/kallsyms.c

+5 −8
Original line number Diff line number Diff line
@@ -20,6 +20,7 @@ 
#include <linux/proc_fs.h>

#include <linux/sched.h>	/* for cond_resched */

#include <linux/mm.h>

#include <linux/ctype.h>



#include <asm/sections.h>
@@ -301,13 +302,6 @@ struct kallsym_iter 
	char name[KSYM_NAME_LEN+1];

};



/* Only label it "global" if it is exported. */

static void upcase_if_global(struct kallsym_iter *iter)

{

	if (is_exported(iter->name, iter->owner))

		iter->type += 'A' - 'a';

}



static int get_ksymbol_mod(struct kallsym_iter *iter)

{

	iter->owner = module_get_kallsym(iter->pos - kallsyms_num_syms,
@@ -316,7 +310,10 @@ static int get_ksymbol_mod(struct kallsym_iter *iter) 
	if (iter->owner == NULL)

		return 0;



	upcase_if_global(iter);

	/* Label it "global" if it is exported, "local" if not exported. */

	iter->type = is_exported(iter->name, iter->owner)

		? toupper(iter->type) : tolower(iter->type);



	return 1;

}