Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06fbc01a authored by Liang Zhen's avatar Liang Zhen Committed by Greg Kroah-Hartman
Browse files

staging/lustre/ptlrpc: false alarm in AT network latency measuring 



If early reply of client RPC is lost and client RPC is expired and
resent, server will drop the resent RPC because it's already in
processing, server may also send reply or early reply to client,
which can still match reply buffer of the original request.
In this case, client is measuring time from resent time, but server
is reporting service time of original RPC, which is longer than
the time measured by client.

Signed-off-by: default avatarLiang Zhen <liang.zhen@intel.com>
Reviewed-on: http://review.whamcloud.com/12855
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5545


Reviewed-by: default avatarLi Wei <wei.g.li@intel.com>
Reviewed-by: default avatarJohann Lombardi <johann.lombardi@intel.com>
Signed-off-by: default avatarOleg Drokin <oleg.drokin@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f4289400

drivers/staging/lustre/lustre/ptlrpc/client.c

+19 −6
Original line number Diff line number Diff line
@@ -285,14 +285,27 @@ static void ptlrpc_at_adj_net_latency(struct ptlrpc_request *req, 
	time_t now = get_seconds();



	LASSERT(req->rq_import);

	at = &req->rq_import->imp_at;



	/* Network latency is total time less server processing time */

	nl = max_t(int, now - req->rq_sent - service_time, 0) + 1/*st rounding*/;

	if (service_time > now - req->rq_sent + 3 /* bz16408 */)

		CWARN("Reported service time %u > total measured time "

	if (service_time > now - req->rq_sent + 3) {

		/* bz16408, however, this can also happen if early reply

		 * is lost and client RPC is expired and resent, early reply

		 * or reply of original RPC can still be fit in reply buffer

		 * of resent RPC, now client is measuring time from the

		 * resent time, but server sent back service time of original

		 * RPC.

		 */

		CDEBUG((lustre_msg_get_flags(req->rq_reqmsg) & MSG_RESENT) ?

		       D_ADAPTTO : D_WARNING,

		       "Reported service time %u > total measured time "

		       CFS_DURATION_T"\n", service_time,

		       cfs_time_sub(now, req->rq_sent));

		return;

	}



	/* Network latency is total time less server processing time */

	nl = max_t(int, now - req->rq_sent -

			service_time, 0) + 1; /* st rounding */

	at = &req->rq_import->imp_at;



	oldnl = at_measured(&at->iat_net_latency, nl);

	if (oldnl != 0)