Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06cd9396 authored Jan 17, 2007 by Li Yang Committed by Paul Mackerras Jan 22, 2007

[POWERPC] Fix OF node refcnt underflow in 836x and 832x platform code



Incorrect use of of_find_node_by_name() causes of_node_put()
on a node which has already been put.  It causes the refcount of
the node to underflow, which triggers the WARN_ON in kref_get
for 836x and 832x.  This fixes it.

Signed-off-by: Li Yang <leoli@freescale.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>

parent 121361f7

arch/powerpc/platforms/83xx/mpc832x_mds.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -103,7 +103,7 @@ static void __init mpc832x_sys_setup_arch(void)
	#ifdef CONFIG_QUICC_ENGINE		#ifdef CONFIG_QUICC_ENGINE
	qe_reset();		qe_reset();

	if ((np = of_find_node_by_name(np, "par_io")) != NULL) {		if ((np = of_find_node_by_name(NULL, "par_io")) != NULL) {
	par_io_init(np);		par_io_init(np);
	of_node_put(np);		of_node_put(np);

arch/powerpc/platforms/83xx/mpc8360e_pb.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -108,7 +108,7 @@ static void __init mpc8360_sys_setup_arch(void)
	#ifdef CONFIG_QUICC_ENGINE		#ifdef CONFIG_QUICC_ENGINE
	qe_reset();		qe_reset();

	if ((np = of_find_node_by_name(np, "par_io")) != NULL) {		if ((np = of_find_node_by_name(NULL, "par_io")) != NULL) {
	par_io_init(np);		par_io_init(np);
	of_node_put(np);		of_node_put(np);