Commit 06be580a authored Sep 01, 2017 by Haiyang Zhang Committed by David S. Miller Sep 01, 2017

hv_netvsc: Simplify the limit check in netvsc_set_channels()



Because of the following code, net->num_tx_queues equals to
VRSS_CHANNEL_MAX, and max_chn is less than or equals to VRSS_CHANNEL_MAX.

netvsc_drv.c:
alloc_etherdev_mq(sizeof(struct net_device_context),
                                VRSS_CHANNEL_MAX);
rndis_filter.c:
net_device->max_chn = min_t(u32, VRSS_CHANNEL_MAX, num_possible_rss_qs);

So this patch removes the unnecessary limit check before comparing
with "max_chn".

Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 5c4217d0

drivers/net/hyperv/netvsc_drv.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -830,9 +830,6 @@ static int netvsc_set_channels(struct net_device *net,
		channels->rx_count \|\| channels->tx_count \|\| channels->other_count)
		return -EINVAL;

		if (count > net->num_tx_queues \|\| count > VRSS_CHANNEL_MAX)
		return -EINVAL;

		if (!nvdev \|\| nvdev->destroy)
		return -ENODEV;