Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 04bf1c7f authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Rafael J. Wysocki
Browse files

PM / OPP: Assert RCU lock in exported functions 



Add lockdep asserts for holding the RCU lock when calling
dev_pm_opp_get_freq() and dev_pm_opp_get_voltage() to aid in detecting
RCU misuses.

These are called often after dev_pm_opp_find_freq_ceil/exact() which
already asserts for RCU lock. However one could make an error by
releasing lock too early - just after dev_pm_opp_find_freq_ceil().

Signed-off-by: default avatarKrzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 984f16c8

drivers/base/power/opp.c

+4 −0
Original line number Diff line number Diff line
@@ -169,6 +169,8 @@ unsigned long dev_pm_opp_get_voltage(struct dev_pm_opp *opp) 
	struct dev_pm_opp *tmp_opp;

	unsigned long v = 0;



	opp_rcu_lockdep_assert();



	tmp_opp = rcu_dereference(opp);

	if (unlikely(IS_ERR_OR_NULL(tmp_opp)) || !tmp_opp->available)

		pr_err("%s: Invalid parameters\n", __func__);
@@ -199,6 +201,8 @@ unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp) 
	struct dev_pm_opp *tmp_opp;

	unsigned long f = 0;



	opp_rcu_lockdep_assert();



	tmp_opp = rcu_dereference(opp);

	if (unlikely(IS_ERR_OR_NULL(tmp_opp)) || !tmp_opp->available)

		pr_err("%s: Invalid parameters\n", __func__);