Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 04aa4438 authored by Lee Jones's avatar Lee Jones
Browse files

mfd: twl4030-irq: Fix style warnings relating to pr_warn() and sizeof() 



This is part of an effort to clean-up the MFD subsystem.

WARNING: Prefer pr_warn(... to pr_warning(...
+               pr_warning("twl4030: I2C error %d reading PIH ISR\n", ret);

WARNING: sizeof buf should be sizeof(buf)
+       memset(buf, 0xff, sizeof buf);

WARNING: sizeof *agent should be sizeof(*agent)
+       agent = kzalloc(sizeof *agent, GFP_KERNEL);

Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 52149ad2

drivers/mfd/twl4030-irq.c

+3 −3
Original line number Diff line number Diff line
@@ -297,7 +297,7 @@ static irqreturn_t handle_twl4030_pih(int irq, void *devid) 
	ret = twl_i2c_read_u8(TWL_MODULE_PIH, &pih_isr,

			      REG_PIH_ISR_P1);

	if (ret) {

		pr_warning("twl4030: I2C error %d reading PIH ISR\n", ret);

		pr_warn("twl4030: I2C error %d reading PIH ISR\n", ret);

		return IRQ_NONE;

	}
@@ -338,7 +338,7 @@ static int twl4030_init_sih_modules(unsigned line) 
	irq_line = line;



	/* disable all interrupts on our line */

	memset(buf, 0xff, sizeof buf);

	memset(buf, 0xff, sizeof(buf));

	sih = sih_modules;

	for (i = 0; i < nr_sih_modules; i++, sih++) {

		/* skip USB -- it's funky */
@@ -646,7 +646,7 @@ int twl4030_sih_setup(struct device *dev, int module, int irq_base) 
	if (status < 0)

		return status;



	agent = kzalloc(sizeof *agent, GFP_KERNEL);

	agent = kzalloc(sizeof(*agent), GFP_KERNEL);

	if (!agent)

		return -ENOMEM;