Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0266ac45 authored by Keller, Jacob E's avatar Keller, Jacob E Committed by David S. Miller
Browse files

i40e: don't truncate match_method assignment 



The .match_method field is a u8, so we shouldn't be casting to a u16,
and because it is only one byte, we do not need to byte swap anything.
Just assign the value directly. This avoids issues on Big Endian
architectures which would have byte swapped and then incorrectly
truncated the value.

Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Bimmy Pujari <bimmy.pujari@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6246168b

drivers/net/ethernet/intel/i40e/i40e_main.c

+1 −2
Original line number Diff line number Diff line
@@ -2196,8 +2196,7 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi) 
			}

			add_list[num_add].queue_number = 0;

			/* set invalid match method for later detection */

			add_list[num_add].match_method =

				cpu_to_le16((u16)I40E_AQC_MM_ERR_NO_RES);

			add_list[num_add].match_method = I40E_AQC_MM_ERR_NO_RES;

			cmd_flags |= I40E_AQC_MACVLAN_ADD_PERFECT_MATCH;

			add_list[num_add].flags = cpu_to_le16(cmd_flags);

			num_add++;