Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 02281a35 authored by Jisheng Zhang's avatar Jisheng Zhang Committed by David S. Miller
Browse files

net: mvneta: remove duplicate *_coal assignment 



The style of the rx/tx queue's *_coal member assignment is:

static void foo_coal_set(...)
{
	set the coal in hw;
	update queue's foo_coal member; [1]
}

In other place, we call foo_coal_set(pp, queue->foo_coal), so the above [1]
is duplicated and could be removed.

Signed-off-by: default avatarJisheng Zhang <Jisheng.Zhang@synaptics.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e7696042

drivers/net/ethernet/marvell/mvneta.c

+0 −4
Original line number Diff line number Diff line
@@ -1555,7 +1555,6 @@ static void mvneta_rx_pkts_coal_set(struct mvneta_port *pp, 
{

	mvreg_write(pp, MVNETA_RXQ_THRESHOLD_REG(rxq->id),

		    value | MVNETA_RXQ_NON_OCCUPIED(0));

	rxq->pkts_coal = value;

}



/* Set the time delay in usec before RX interrupt will be generated by
@@ -1571,7 +1570,6 @@ static void mvneta_rx_time_coal_set(struct mvneta_port *pp, 
	val = (clk_rate / 1000000) * value;



	mvreg_write(pp, MVNETA_RXQ_TIME_COAL_REG(rxq->id), val);

	rxq->time_coal = value;

}



/* Set threshold for TX_DONE pkts coalescing */
@@ -1586,8 +1584,6 @@ static void mvneta_tx_done_pkts_coal_set(struct mvneta_port *pp, 
	val |= MVNETA_TXQ_SENT_THRESH_MASK(value);



	mvreg_write(pp, MVNETA_TXQ_SIZE_REG(txq->id), val);



	txq->done_pkts_coal = value;

}



/* Handle rx descriptor fill by setting buf_cookie and buf_phys_addr */