Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 021afd55 authored by Srinivas Pandruvada's avatar Srinivas Pandruvada Committed by Jiri Kosina
Browse files

HID: intel-ish-hid: request_irq failure 



On some platforms ISH interrupt is shared, which causes request_irq to
fail. This requires IRQF_SHARED irq flag.

But IRQF_NO_SUSPEND and IRQF_SHARED should not be used together, so
removed IRQF_NO_SUSPEND flag. Anyway this driver doesn't require
IRQF_NO_SUSPEND, as this interrupt is not required during "noirq" phases
of suspending and resuming devices as well as during the time when
nonboot CPUs are taken offline and brought back online.

Signed-off-by: default avatarSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 2a1e3b93

drivers/hid/intel-ish-hid/ipc/pci-ish.c

+1 −1
Original line number Diff line number Diff line
@@ -146,7 +146,7 @@ static int ish_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
	pdev->dev_flags |= PCI_DEV_FLAGS_NO_D3;



	/* request and enable interrupt */

	ret = request_irq(pdev->irq, ish_irq_handler, IRQF_NO_SUSPEND,

	ret = request_irq(pdev->irq, ish_irq_handler, IRQF_SHARED,

			  KBUILD_MODNAME, dev);

	if (ret) {

		dev_err(&pdev->dev, "ISH: request IRQ failure (%d)\n",