Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 01cda8d3 authored by Christian Engelmayer's avatar Christian Engelmayer Committed by Greg Kroah-Hartman
Browse files

staging: silicom: Remove needless calls of get_status_port_fn() 



Remove a needless pointer initialisation and call to get_status_port_fn()
in functions remove_bypass_tpl_auto() and set_tpl_fn(). Variable
'pbpctl_dev_b' is set correctly later in the function before first use.

Signed-off-by: default avatarChristian Engelmayer <cengelma@gmx.at>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ea3528c2

drivers/staging/silicom/bpctl_mod.c

+2 −5
Original line number Diff line number Diff line
@@ -4735,10 +4735,9 @@ static void bp_tpl_timer_fn(unsigned long param) 


static void remove_bypass_tpl_auto(struct bpctl_dev *pbpctl_dev)

{

	struct bpctl_dev *pbpctl_dev_b = NULL;

	struct bpctl_dev *pbpctl_dev_b;

	if (!pbpctl_dev)

		return;

	pbpctl_dev_b = get_status_port_fn(pbpctl_dev);



	if (pbpctl_dev->bp_caps & TPL_CAP) {

		del_timer_sync(&pbpctl_dev->bp_tpl_timer);
@@ -4785,12 +4784,10 @@ static int set_bypass_tpl_auto(struct bpctl_dev *pbpctl_dev, unsigned int param) 
static int set_tpl_fn(struct bpctl_dev *pbpctl_dev, int tpl_mode)

{



	struct bpctl_dev *pbpctl_dev_b = NULL;

	struct bpctl_dev *pbpctl_dev_b;

	if (!pbpctl_dev)

		return -1;



	pbpctl_dev_b = get_status_port_fn(pbpctl_dev);



	if (pbpctl_dev->bp_caps & TPL_CAP) {

		if (tpl_mode) {

			pbpctl_dev_b = get_status_port_fn(pbpctl_dev);