Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0103fe20 authored by Amitoj Kaur Chawla's avatar Amitoj Kaur Chawla Committed by Greg Kroah-Hartman
Browse files

staging: android: Use devm_kcalloc instead of devm_kzalloc 



Replace devm_kzalloc with devm_kcalloc to ensure there are no integer
overflows from the multiplication of a number * sizeof.

The following Coccinelle semantic patch was used to make this change:
//<smpl>
@@
expression dev,E1,E2,E3;
@@
- devm_kzalloc(dev,E1*sizeof(E2),E3)
+ devm_kcalloc(dev,E1,sizeof(E2),E3)
//</smpl>

Signed-off-by: default avatarAmitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9f1c427d

drivers/staging/android/timed_gpio.c

+2 −3
Original line number Diff line number Diff line
@@ -92,9 +92,8 @@ static int timed_gpio_probe(struct platform_device *pdev) 
	if (!pdata)

		return -EBUSY;



	gpio_data = devm_kzalloc(&pdev->dev,

				 sizeof(*gpio_data) * pdata->num_gpios,

				 GFP_KERNEL);

	gpio_data = devm_kcalloc(&pdev->dev, pdata->num_gpios,

				 sizeof(*gpio_data), GFP_KERNEL);

	if (!gpio_data)

		return -ENOMEM;