Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 00251488 authored by Li Jun's avatar Li Jun Committed by Greg Kroah-Hartman
Browse files

staging: typec: tcpci: Only touch target bit when enable vconn 



We need regmap_update_bits to avoid touch any other bits when
enable or disable vconn.

Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: default avatarLi Jun <jun.li@nxp.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3af50c29

drivers/staging/typec/tcpci.c

+3 −6
Original line number Diff line number Diff line
@@ -218,12 +218,9 @@ static int tcpci_set_vconn(struct tcpc_dev *tcpc, bool enable) 
			return ret;

	}



	ret = regmap_write(tcpci->regmap, TCPC_POWER_CTRL,

	return regmap_update_bits(tcpci->regmap, TCPC_POWER_CTRL,

				TCPC_POWER_CTRL_VCONN_ENABLE,

				enable ? TCPC_POWER_CTRL_VCONN_ENABLE : 0);

	if (ret < 0)

		return ret;



	return 0;

}



static int tcpci_set_roles(struct tcpc_dev *tcpc, bool attached,