Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ffb91a45 authored by Peter Hurley's avatar Peter Hurley Committed by Greg Kroah-Hartman
Browse files

n_tty: Remove tty count checks from unthrottle 



Since n_tty_check_unthrottle() is only called from n_tty_read()
which only originates from a userspace read(), the tty count cannot
be 0; the read() guarantees the file descriptor has not yet been
released.

Signed-off-by: default avatarPeter Hurley <peter@hurleysoftware.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7bccc365

drivers/tty/n_tty.c

+0 −4
Original line number Diff line number Diff line
@@ -261,8 +261,6 @@ static void n_tty_check_unthrottle(struct tty_struct *tty) 
	if (tty->driver->type == TTY_DRIVER_TYPE_PTY) {

		if (chars_in_buffer(tty) > TTY_THRESHOLD_UNTHROTTLE)

			return;

		if (!tty->count)

			return;

		n_tty_kick_worker(tty);

		tty_wakeup(tty->link);

		return;
@@ -281,8 +279,6 @@ static void n_tty_check_unthrottle(struct tty_struct *tty) 
		tty_set_flow_change(tty, TTY_UNTHROTTLE_SAFE);

		if (chars_in_buffer(tty) > TTY_THRESHOLD_UNTHROTTLE)

			break;

		if (!tty->count)

			break;

		n_tty_kick_worker(tty);

		unthrottled = tty_unthrottle_safe(tty);

		if (!unthrottled)