Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ff9df8c8 authored by Daniel Axtens's avatar Daniel Axtens Committed by Michael Ellerman
Browse files

powerpc: Create pci_controller_ops.probe_mode and shim 



Add pci_controller_ops.probe_mode, shadowing ppc_md.pci_probe_mode.
Add a shim, and changes the callsites to use the shim.

We also need to move the probe mode defines to pci-bridge.h from pci.h.
They are required by the shim in order to return a sensible default.
Previously, the were defined in pci.h, but pci.h includes pci-bridge.h
before the relevant #defines. This means the definitions are absent
if pci.h is included before pci-bridge.h. This occurs in some drivers.
So, move the definitons now, and move them back when we remove the shim.

Anything that wants the defines would have had to include pci.h, and
since pci.h includes pci-bridge.h, nothing will lose access to the
defines.

Signed-off-by: default avatarDaniel Axtens <dja@axtens.net>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent b122c954

arch/powerpc/include/asm/pci-bridge.h

+18 −0
Original line number Diff line number Diff line
@@ -12,6 +12,11 @@ 
#include <linux/ioport.h>

#include <asm-generic/pci-bridge.h>



/* Return values for pci_controller_ops.probe_mode function */

#define PCI_PROBE_NONE		-1	/* Don't look at this bus at all */

#define PCI_PROBE_NORMAL	0	/* Do normal PCI probing */

#define PCI_PROBE_DEVTREE	1	/* Instantiate from device tree */



struct device_node;



/*
@@ -20,6 +25,8 @@ struct device_node; 
struct pci_controller_ops {

	void		(*dma_dev_setup)(struct pci_dev *dev);

	void		(*dma_bus_setup)(struct pci_bus *bus);



	int		(*probe_mode)(struct pci_bus *);

};



/*
@@ -292,5 +299,16 @@ static inline void pci_dma_bus_setup(struct pci_bus *bus) 
		ppc_md.pci_dma_bus_setup(bus);

}



static inline int pci_probe_mode(struct pci_bus *bus)

{

	struct pci_controller *phb = pci_bus_to_host(bus);



	if (phb->controller_ops.probe_mode)

		return phb->controller_ops.probe_mode(bus);

	if (ppc_md.pci_probe_mode)

		return ppc_md.pci_probe_mode(bus);

	return PCI_PROBE_NORMAL;

}



#endif	/* __KERNEL__ */

#endif	/* _ASM_POWERPC_PCI_BRIDGE_H */

arch/powerpc/include/asm/pci.h

+0 −5
Original line number Diff line number Diff line
@@ -22,11 +22,6 @@ 


#include <asm-generic/pci-dma-compat.h>



/* Return values for ppc_md.pci_probe_mode function */

#define PCI_PROBE_NONE		-1	/* Don't look at this bus at all */

#define PCI_PROBE_NORMAL	0	/* Do normal PCI probing */

#define PCI_PROBE_DEVTREE	1	/* Instantiate from device tree */



#define PCIBIOS_MIN_IO		0x1000

#define PCIBIOS_MIN_MEM		0x10000000

arch/powerpc/kernel/pci-common.c

+2 −2
Original line number Diff line number Diff line
@@ -1622,8 +1622,8 @@ void pcibios_scan_phb(struct pci_controller *hose) 


	/* Get probe mode and perform scan */

	mode = PCI_PROBE_NORMAL;

	if (node && ppc_md.pci_probe_mode)

		mode = ppc_md.pci_probe_mode(bus);

	if (node)

		mode = pci_probe_mode(bus);

	pr_debug("    probe mode: %d\n", mode);

	if (mode == PCI_PROBE_DEVTREE)

		of_scan_bus(node, bus);

arch/powerpc/kernel/pci-hotplug.c

+1 −2
Original line number Diff line number Diff line
@@ -78,8 +78,7 @@ void pcibios_add_pci_devices(struct pci_bus * bus) 
	eeh_add_device_tree_early(PCI_DN(dn));



	mode = PCI_PROBE_NORMAL;

	if (ppc_md.pci_probe_mode)

		mode = ppc_md.pci_probe_mode(bus);

	mode = pci_probe_mode(bus);



	if (mode == PCI_PROBE_DEVTREE) {

		/* use ofdt-based probe */

arch/powerpc/kernel/pci_of_scan.c

+1 −2
Original line number Diff line number Diff line
@@ -287,8 +287,7 @@ void of_scan_pci_bridge(struct pci_dev *dev) 
	pr_debug("    bus name: %s\n", bus->name);



	mode = PCI_PROBE_NORMAL;

	if (ppc_md.pci_probe_mode)

		mode = ppc_md.pci_probe_mode(bus);

	mode = pci_probe_mode(bus);

	pr_debug("    probe mode: %d\n", mode);



	if (mode == PCI_PROBE_DEVTREE)