Commit ff79ae80 authored Nov 12, 2008 by Yossi Etigin Committed by Roland Dreier Nov 12, 2008

IPoIB: Fix crash in path_rec_completion()

Fix a crash in path_rec_completion() during an SM up/down loop.  If
more than one path record request is issued, the first completion
releases path->done, allowing ipoib_flush_paths() to free the path,
and thus corrupting it for the second completion.

Commit ee1e2c82 ("IPoIB: Refresh paths instead of flushing them on SM
change events") added the field path->valid and changed the test "if
(!path)" to "if (!path || !path->valid)".  This change made it
possible for a path with an outstanding query to pass the test and
issue another query on the same path.  Having two queries on the same
path leads to a crash.

This fixes <https://bugs.openfabrics.org/show_bug.cgi?id=1325

>.

Signed-off-by: Yossi Etigin <yosefe@voltaire.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>

parent 93a3ab93

drivers/infiniband/ulp/ipoib/ipoib_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -664,7 +664,7 @@ static void unicast_arp_send(struct sk_buff skb, struct net_device dev,
		skb_push(skb, sizeof *phdr);
		__skb_queue_tail(&path->queue, skb);

		if (path_rec_start(dev, path)) {
		if (!path->query && path_rec_start(dev, path)) {
		spin_unlock_irqrestore(&priv->lock, flags);
		path_free(dev, path);
		return;