Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ff59dc76 authored by Johannes Berg's avatar Johannes Berg Committed by John W. Linville
Browse files

mac80211: add missing "break" statement in mesh code 



This inserts a missing break statement which, if hit, would cause
the code to fall-through and unlock a spinlock twice. Noticed via
sparse's "lock count wrong in basic block" warning and careful
code inspection.

Signed-off-by: default avatarJohannes Berg <johannes@sipsolutions.net>
Cc: Luis Carlos Cobo <luisca@cozybit.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 2f5ce793

net/mac80211/mesh_plink.c

+1 −0
Original line number Original line Diff line number Diff line
@@ -691,6 +691,7 @@ void mesh_rx_plink_frame(struct net_device *dev, struct ieee80211_mgmt *mgmt, 
			spin_unlock_bh(&sta->plink_lock);

			spin_unlock_bh(&sta->plink_lock);

			mesh_plink_frame_tx(dev, PLINK_CLOSE, sta->addr, llid,

			mesh_plink_frame_tx(dev, PLINK_CLOSE, sta->addr, llid,

					    plid, reason);

					    plid, reason);

			break;

		case OPN_ACPT:

		case OPN_ACPT:

			if (del_timer(&sta->plink_timer))

			if (del_timer(&sta->plink_timer))

				sta_info_put(sta);

				sta_info_put(sta);