Commit fef0ebdb authored Jan 06, 2013 by Guo Chao Committed by Theodore Ts'o Jan 06, 2013

ext4: remove duplicate call to ext4_bread() in ext4_init_new_dir()



This fixes a buffer cache leak when creating a directory, introduced
in commit a774f9c2.

Signed-off-by: Guo Chao <yan@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Reviewed-by: Tao Ma <boyu.mt@taobao.com>

parent 0ecaef06

fs/ext4/namei.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -2368,7 +2368,6 @@ static int ext4_init_new_dir(handle_t handle, struct inode dir,
		}

		inode->i_size = EXT4_I(inode)->i_disksize = blocksize;
		dir_block = ext4_bread(handle, inode, 0, 1, &err);
		if (!(dir_block = ext4_bread(handle, inode, 0, 1, &err))) {
		if (!err) {
		err = -EIO;