Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fee4b700 authored by Eldad Zack's avatar Eldad Zack Committed by Takashi Iwai
Browse files

ALSA: hiface: return correct XRUN indication 



Return SNDRV_PCM_POS_XRUN (snd_pcm_uframes_t) instead of
SNDRV_PCM_STATE_XRUN (snd_pcm_state_t) from the pointer
function of hiface, as expected by snd_pcm_update_hw_ptr0().

Caught by sparse.

Cc: Antonio Ospite <ospite@studenti.unina.it>
Signed-off-by: default avatarEldad Zack <eldad@fogrefinery.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent be2f93a4

sound/usb/hiface/pcm.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -503,7 +503,7 @@ static snd_pcm_uframes_t hiface_pcm_pointer(struct snd_pcm_substream *alsa_sub) 
	snd_pcm_uframes_t dma_offset;

	snd_pcm_uframes_t dma_offset;





	if (rt->panic || !sub)

	if (rt->panic || !sub)

		return SNDRV_PCM_STATE_XRUN;

		return SNDRV_PCM_POS_XRUN;





	spin_lock_irqsave(&sub->lock, flags);

	spin_lock_irqsave(&sub->lock, flags);

	dma_offset = sub->dma_off;

	dma_offset = sub->dma_off;