Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fdf26d93 authored by Ashok Raj's avatar Ashok Raj Committed by Linus Torvalds
Browse files

[PATCH] x86_64: Don't do broadcast IPIs when hotplug is enabled in flat mode. 



The use of non-shortcut version of routines breaking CPU hotplug.  The option
to select this via cmdline also is deleted with the physflat patch, hence
directly placing this code under CONFIG_HOTPLUG_CPU.

We dont want to use broadcast mode IPI's when hotplug is enabled.  This causes
bad effects in send IPI to a cpu that is offline which can trip when the cpu
is in the process of being kicked alive.

Signed-off-by: default avatarAshok Raj <ashok.raj@intel.com>
Acked-by: default avatarAndi Kleen <ak@muc.de>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 4c7fc722

arch/x86_64/kernel/genapic_flat.c

+10 −0
Original line number Diff line number Diff line
@@ -78,8 +78,18 @@ static void flat_send_IPI_mask(cpumask_t cpumask, int vector) 


static void flat_send_IPI_allbutself(int vector)

{

#ifndef CONFIG_HOTPLUG_CPU

	if (((num_online_cpus()) - 1) >= 1)

		__send_IPI_shortcut(APIC_DEST_ALLBUT, vector,APIC_DEST_LOGICAL);

#else

	cpumask_t allbutme = cpu_online_map;

	int me = get_cpu(); /* Ensure we are not preempted when we clear */

	cpu_clear(me, allbutme);



	if (!cpus_empty(allbutme))

		flat_send_IPI_mask(allbutme, vector);

	put_cpu();

#endif

}



static void flat_send_IPI_all(int vector)