Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fdab6a4c authored by Eric W. Biederman's avatar Eric W. Biederman Committed by David S. Miller
Browse files

netfilter: nftables: Do not run chains in the wrong network namespace 



Currenlty nf_tables chains added in one network namespace are being
run in all network namespace.  The issues are myriad with the simplest
being an unprivileged user can cause any network packets to be dropped.

Address this by simply not running nf_tables chains in the wrong
network namespace.

Cc: stable@vger.kernel.org
Signed-off-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent dfe816c5

net/netfilter/nf_tables_core.c

+6 −1
Original line number Original line Diff line number Diff line
@@ -114,7 +114,8 @@ unsigned int 
nft_do_chain(struct nft_pktinfo *pkt, const struct nf_hook_ops *ops)

nft_do_chain(struct nft_pktinfo *pkt, const struct nf_hook_ops *ops)

{

{

	const struct nft_chain *chain = ops->priv, *basechain = chain;

	const struct nft_chain *chain = ops->priv, *basechain = chain;

	const struct net *net = read_pnet(&nft_base_chain(basechain)->pnet);

	const struct net *chain_net = read_pnet(&nft_base_chain(basechain)->pnet);

	const struct net *net = dev_net(pkt->in ? pkt->in : pkt->out);

	const struct nft_rule *rule;

	const struct nft_rule *rule;

	const struct nft_expr *expr, *last;

	const struct nft_expr *expr, *last;

	struct nft_regs regs;

	struct nft_regs regs;
@@ -124,6 +125,10 @@ nft_do_chain(struct nft_pktinfo *pkt, const struct nf_hook_ops *ops) 
	int rulenum;

	int rulenum;

	unsigned int gencursor = nft_genmask_cur(net);

	unsigned int gencursor = nft_genmask_cur(net);





	/* Ignore chains that are not for the current network namespace */

	if (!net_eq(net, chain_net))

		return NF_ACCEPT;



do_chain:

do_chain:

	rulenum = 0;

	rulenum = 0;

	rule = list_entry(&chain->rules, struct nft_rule, list);

	rule = list_entry(&chain->rules, struct nft_rule, list);