Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fc1645ac authored by Daniel Vetter's avatar Daniel Vetter
Browse files

drm/imx: remove drm_mode_connector_detach_encoder harder 



Since the last time I've looked more of this stuff sprouted up. Stomp
it down again.

Repeating the original justification for ripping this all out: There's
absolutely no need to deteach connectors before cleaning them up at
driver unload time. And since drm doesn't support hotplugging kms
objects at all it's positively dangerous to attempt this at runtime.
Luckily imx only detachs at driver cleanup time and hence we can
savely remove this.

Reported-by: default avatarkbuild test robot <fengguang.wu@intel.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent c8e32cc1

drivers/staging/imx-drm/imx-hdmi.c

+0 −1
Original line number Diff line number Diff line
@@ -1883,7 +1883,6 @@ static int imx_hdmi_platform_remove(struct platform_device *pdev) 
	struct drm_connector *connector = &hdmi->connector;

	struct drm_encoder *encoder = &hdmi->encoder;



	drm_mode_connector_detach_encoder(connector, encoder);

	imx_drm_remove_connector(hdmi->imx_drm_connector);

	imx_drm_remove_encoder(hdmi->imx_drm_encoder);

drivers/staging/imx-drm/imx-tve.c

+0 −2
Original line number Diff line number Diff line
@@ -709,8 +709,6 @@ static int imx_tve_remove(struct platform_device *pdev) 
	struct drm_connector *connector = &tve->connector;

	struct drm_encoder *encoder = &tve->encoder;



	drm_mode_connector_detach_encoder(connector, encoder);



	imx_drm_remove_connector(tve->imx_drm_connector);

	imx_drm_remove_encoder(tve->imx_drm_encoder);