Commit fbf40727 authored Jun 22, 2015 by Javier Martinez Canillas Committed by Olof Johansson Oct 07, 2015

platform/chrome: cros_ec_lpc - Use existing function to check EC result



Commit 6db07b63 ("mfd: cros_ec: Check result code from EC messages")
added a common cros_ec_check_result() function that can be used to check
the ec_msg->result for errors and warns about them.

Use the existing function instead of duplicating same check in the driver.

Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
Tested-by: Gwendal Grignou <gwendal@chromium.org>
Signed-off-by: Olof Johansson <olof@lixom.net>

parent 75529a9d

drivers/platform/chrome/cros_ec_lpc.c

+2 −12

Original line number	Diff line number	Diff line
		@@ -166,19 +166,9 @@ static int cros_ec_cmd_xfer_lpc(struct cros_ec_device *ec,

		/* Check result */
		msg->result = inb(EC_LPC_ADDR_HOST_DATA);

		switch (msg->result) {
		case EC_RES_SUCCESS:
		break;
		case EC_RES_IN_PROGRESS:
		ret = -EAGAIN;
		dev_dbg(ec->dev, "command 0x%02x in progress\n",
		msg->command);
		ret = cros_ec_check_result(ec, msg);
		if (ret)
		goto done;
		default:
		dev_dbg(ec->dev, "command 0x%02x returned %d\n",
		msg->command, msg->result);
		}

		/* Read back args */
		args.flags = inb(EC_LPC_ADDR_HOST_ARGS);