Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fbe5e29e authored by Daniel Schwierzeck's avatar Daniel Schwierzeck Committed by David S. Miller
Browse files

atm: br2684: Fix oops due to skb->dev being NULL 



This oops have been already fixed with commit

    27141666

    atm: [br2684] Fix oops due to skb->dev being NULL

    It happens that if a packet arrives in a VC between the call to open it on
    the hardware and the call to change the backend to br2684, br2684_regvcc
    processes the packet and oopses dereferencing skb->dev because it is
    NULL before the call to br2684_push().

but have been introduced again with commit

    b6211ae7

    atm: Use SKB queue and list helpers instead of doing it by-hand.

Signed-off-by: default avatarDaniel Schwierzeck <daniel.schwierzeck@googlemail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 98e77438

net/atm/br2684.c

+4 −3
Original line number Diff line number Diff line
@@ -558,12 +558,13 @@ static int br2684_regvcc(struct atm_vcc *atmvcc, void __user * arg) 
	spin_unlock_irqrestore(&rq->lock, flags);



	skb_queue_walk_safe(&queue, skb, tmp) {

		struct net_device *dev = skb->dev;

		struct net_device *dev;



		br2684_push(atmvcc, skb);

		dev = skb->dev;



		dev->stats.rx_bytes -= skb->len;

		dev->stats.rx_packets--;



		br2684_push(atmvcc, skb);

	}



	/* initialize netdev carrier state */