Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fbb7997e authored Jun 19, 2015 by Arnaldo Carvalho de Melo

perf top: Replace CTRL+z with 'f' as hotkey for enable/disable events

I.e. 'freeze'/'unfreeze', this is because CTRL+z has a well known
action, i.e. suspend the app, perf needs to follow that convention, that
will be done on a separate patch, tho.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-oedcl6ovohara4koig14ayip@git.kernel.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 276af92f

tools/perf/builtin-top.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -591,7 +591,7 @@ static void display_thread_tui(void arg)
		top->min_percent,
		&top->session->header.env);

		if (key != CTRL('z'))
		if (key != 'f')
		break;

		perf_evlist__toggle_enable(top->evlist);

tools/perf/ui/browsers/hists.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1736,7 +1736,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
		"t Zoom into current Thread\n"
		"V Verbose (DSO names in callchains, etc)\n"
		"z Toggle zeroing of samples\n"
		"CTRL+z Enable/Disable events\n"
		"f Enable/Disable events\n"
		"/ Filter symbol by name";

		if (browser == NULL)
		@@ -1901,7 +1901,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
		/* Fall thru */
		case 'q':
		case CTRL('c'):
		case CTRL('z'):
		case 'f':
		goto out_free_stack;
		default:
		continue;