Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fac1f485 authored by Hans de Goede's avatar Hans de Goede Committed by Greg Kroah-Hartman
Browse files

uas: Add response iu handling 



If something goes wrong in our communication with an uas device we may get
a response iu in reaction to a cmnd, rather then a status iu. In this case
propagate an error upwards, rather then logging a bogus iu message.

Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ce39fe6f

drivers/usb/storage/uas.c

+10 −0
Original line number Original line Diff line number Diff line
@@ -328,6 +328,16 @@ static void uas_stat_cmplt(struct urb *urb) 
		}

		}

		uas_xfer_data(urb, cmnd, SUBMIT_DATA_OUT_URB);

		uas_xfer_data(urb, cmnd, SUBMIT_DATA_OUT_URB);

		break;

		break;

	case IU_ID_RESPONSE:

		uas_log_cmd_state(cmnd, "unexpected response iu",

				  ((struct response_iu *)iu)->response_code);

		/* Error, cancel data transfers */

		data_in_urb = usb_get_urb(cmdinfo->data_in_urb);

		data_out_urb = usb_get_urb(cmdinfo->data_out_urb);

		cmdinfo->state &= ~COMMAND_INFLIGHT;

		cmnd->result = DID_ERROR << 16;

		uas_try_complete(cmnd, __func__);

		break;

	default:

	default:

		uas_log_cmd_state(cmnd, "bogus IU", iu->iu_id);

		uas_log_cmd_state(cmnd, "bogus IU", iu->iu_id);

	}

	}