Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit faa72533 authored by Adrian Bunk's avatar Adrian Bunk Committed by Jeff Garzik
Browse files

[PATCH] SCSI_SATA has to be a tristate



SCSI=m must disallow static drivers.

The problem is that all the SATA drivers depend on SCSI_SATA.

With SCSI=m and SCSI_SATA=y this allows the static enabling of the SATA
drivers with unwanted effects, e.g.:
- SCSI=m, SCSI_SATA=y, SCSI_ATA_ADMA=y
  -> SCSI_ATA_ADMA is built statically but scsi/built-in.o is not linked
     into the kernel
- SCSI=m, SCSI_SATA=y, SCSI_ATA_ADMA=y, SCSI_SATA_AHCI=m
  -> SCSI_ATA_ADMA and libata are built statically but
     scsi/built-in.o is not linked into the kernel,
     SCSI_SATA_AHCI is built modular (unresolved symbols due to missing
                                      libata)

Signed-off-by: default avatarAdrian Bunk <bunk@stusta.de>
Cc: Jeff Garzik <jgarzik@pobox.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarJeff Garzik <jgarzik@pobox.com>
parent b0825488
Loading
Loading
Loading
Loading
+1 −1
Original line number Original line Diff line number Diff line
@@ -424,7 +424,7 @@ config SCSI_IN2000
source "drivers/scsi/megaraid/Kconfig.megaraid"
source "drivers/scsi/megaraid/Kconfig.megaraid"


config SCSI_SATA
config SCSI_SATA
	bool "Serial ATA (SATA) support"
	tristate "Serial ATA (SATA) support"
	depends on SCSI
	depends on SCSI
	help
	help
	  This driver family supports Serial ATA host controllers
	  This driver family supports Serial ATA host controllers